From: James Bottomley <James.Bottomley@SteelEye.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Blacklist devices that falsely claim an echo buffer
Date: 06 Dec 2004 08:59:13 -0600 [thread overview]
Message-ID: <1102345160.2018.1.camel@mulgrave> (raw)
In-Reply-To: <20041203201937.GJ29370@parcelfarce.linux.theplanet.co.uk>
On Fri, 2004-12-03 at 14:19, Matthew Wilcox wrote:
> + if ((sreq->sr_device->scsi_level < SCSI_3) &&
> + ((buffer[0] & 0xfe) || buffer[1] || (buffer[2] & 0xe0))) {
> + /* Device is probably lying to us. Skip write tests. */
> + SPI_PRINTK(sreq->sr_device->sdev_target, KERN_INFO,
> + "Target reports bogus echo buffer\n");
> + return 0;
> + }
> +
Well ... I'm not very keen on this. Does the device support LVD? i.e.
could we use the sreq->sr_device->ppr flag as a discriminator? Write
echo buffer tests are really most useful for validating high LVD
transfer speeds, so it wouldn't be unreasonable simply to skip them if
the device isn't ppr capable.
James
next prev parent reply other threads:[~2004-12-06 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-03 20:19 [PATCH] Blacklist devices that falsely claim an echo buffer Matthew Wilcox
2004-12-06 14:59 ` James Bottomley [this message]
2004-12-06 20:54 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102345160.2018.1.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox