From: James Bottomley <James.Bottomley@SteelEye.com>
To: James.Smart@Emulex.Com
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH] Another fix for suspend i/o - validate dev statebefore transition
Date: Sat, 11 Dec 2004 07:39:18 -0600 [thread overview]
Message-ID: <1102772358.5226.3.camel@mulgrave> (raw)
In-Reply-To: <0B1E13B586976742A7599D71A6AC733C12E89D@xbl3.ma.emulex.com>
On Sat, 2004-12-11 at 07:57 -0500, James.Smart@Emulex.Com wrote:
> Upon further reflection... perhaps I was too hasty agreeing with the change.
>
> It certainly solve my issue. However, what it means is that it may actually hide reports of other invalid state transitions that may be meaningful. Do we want to hide these too ? If not, than I think the original patch best solves the problem. Your call...
Well, that's what worried me when I first implemented the state model,
which is why the message is there. However, there haven't actually been
any bug reports where it did anything other than cause problems. If
there's really a transition we should be warning about failure on, we
can do it by printing an error on the failure return from
scsi_device_set_state().
James
next prev parent reply other threads:[~2004-12-11 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-11 12:57 [PATCH] Another fix for suspend i/o - validate dev statebefore transition James.Smart
2004-12-11 13:39 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-11 12:12 James.Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102772358.5226.3.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox