From: James Bottomley <James.Bottomley@SteelEye.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] convert 53c700 driver to use change_queue_depth API
Date: Wed, 22 Dec 2004 10:53:33 -0600 [thread overview]
Message-ID: <1103734414.5290.8.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.60.0412201700350.16691@poirot.grange>
On Mon, 2004-12-20 at 17:04 +0100, Guennadi Liakhovetski wrote:
> On Mon, 20 Dec 2004, Guennadi Liakhovetski wrote:
>
> > Shouldn't it really be something like
> >
> > if(depth > NCR_700_MAX_TAGS)
> > - return -EINVAL;
> > + depth = NCR_700_MAX_TAGS;
> > + if (depth < 0)
> > + depth = 0;
>
> Ahh, yeah, sure, because of the simple_strtoul incompatibility with glibc
> this check is superfluous, but, the below doubt still remains
Actually, depth may never be zero. There is a check in an updated piece
of code which I'll send out shortly that checks it is never less than
one (in the main routine). This got folded into an update I did and
then not properly separated again.
I'll send the update under a new subject.
James
prev parent reply other threads:[~2004-12-22 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-12 0:54 [PATCH] convert 53c700 driver to use change_queue_depth API James Bottomley
2004-12-20 15:42 ` Guennadi Liakhovetski
2004-12-20 16:04 ` Guennadi Liakhovetski
2004-12-22 16:53 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103734414.5290.8.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox