From: James Bottomley <James.Bottomley@SteelEye.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: implement change_queue_depth
Date: Mon, 27 Dec 2004 12:31:38 -0600 [thread overview]
Message-ID: <1104172298.7447.10.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.60.0412262034030.3808@poirot.grange>
On Sun, 2004-12-26 at 22:49 +0100, Guennadi Liakhovetski wrote:
> Ok. Would it make sense / be accepted to change this sitation by either 1)
> adding a new function __scsi_adjust_queue_depth() which would pass the
> return code of the block-layer, or 2) modifying the existing function to
> return an error? 1) has disadvantages, that it's a) confusing, b) even
> more confusing, because that other function also has to be exported. 2)
> has the disadvantage of changing an exported API in the "stable" series...
> I would go for 2) especially with the current extended understanding of
> the "stable" kernel series. I could roll a patch for either of these 2
> possibilities, if the latter is chosen I could try to fix the current
> users to check the return code.
To be honest, unless you can find a driver that cares about this
failure, I don't think so.
James
next prev parent reply other threads:[~2004-12-27 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-22 12:15 [PATCH] tmscsim: implement change_queue_depth Guennadi Liakhovetski
2004-12-23 18:34 ` James Bottomley
2004-12-25 0:36 ` Guennadi Liakhovetski
2004-12-26 15:49 ` James Bottomley
2004-12-26 21:49 ` Guennadi Liakhovetski
2004-12-27 18:31 ` James Bottomley [this message]
2004-12-28 0:29 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104172298.7447.10.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox