Re: PATCH: fix crashes with aacraid

Mark Haverkamp
2005-01-03T17:05:26Z

On Mon, 2004-12-27 at 14:43 +0000, Alan Cox wrote:
> Is this change still needed for 2.6.10 Mark ?

I thought that the consensus was to remove aac_handle_aif altogether
like the patch sent in by Tom Coughlan on Dec. 8th.

Mark

>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c linux-2.6.10/drivers/scsi/aacraid/commsup.c
> --- linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c 2004-12-25 21:14:35.000000000 +0000
> +++ linux-2.6.10/drivers/scsi/aacraid/commsup.c 2004-12-26 18:53:37.261691936 +0000
> @@ -781,6 +781,7 @@
> static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)
> {
> struct hw_fib * hw_fib = fibptr->hw_fib;
> +#if 0
> /*
> * Set the status of this FIB to be Invalid parameter.
> *
> @@ -788,6 +789,8 @@
> */
> *(u32 *)hw_fib->data = cpu_to_le32(ST_OK);
> fib_adapter_complete(fibptr, sizeof(u32));
> + /* This will be done on our return */
> +#endif
> }
>
> /**
--
Mark Haverkamp <markh@osdl.org>