PATCH: fix crashes with aacraid

PATCH: fix crashes with aacraid

[Alan Cox]

Is this change still needed for 2.6.10  Mark ?

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c linux-2.6.10/drivers/scsi/aacraid/commsup.c
--- linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c	2004-12-25 21:14:35.000000000 +0000
+++ linux-2.6.10/drivers/scsi/aacraid/commsup.c	2004-12-26 18:53:37.261691936 +0000
@@ -781,6 +781,7 @@
 static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)
 {
 	struct hw_fib * hw_fib = fibptr->hw_fib;
+#if 0	
 	/*
 	 * Set the status of this FIB to be Invalid parameter.
 	 *
@@ -788,6 +789,8 @@
 	 */
 	*(u32 *)hw_fib->data = cpu_to_le32(ST_OK);
 	fib_adapter_complete(fibptr, sizeof(u32));
+	/* This will be done on our return */
+#endif
 }
 
 /**

Re: PATCH: fix crashes with aacraid

[Mark Haverkamp]

On Mon, 2004-12-27 at 14:43 +0000, Alan Cox wrote:
> Is this change still needed for 2.6.10  Mark ?

I thought that the consensus was to remove aac_handle_aif altogether
like the patch sent in by Tom Coughlan on Dec. 8th.

Mark


> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c linux-2.6.10/drivers/scsi/aacraid/commsup.c
> --- linux.vanilla-2.6.10/drivers/scsi/aacraid/commsup.c	2004-12-25 21:14:35.000000000 +0000
> +++ linux-2.6.10/drivers/scsi/aacraid/commsup.c	2004-12-26 18:53:37.261691936 +0000
> @@ -781,6 +781,7 @@
>  static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr)
>  {
>  	struct hw_fib * hw_fib = fibptr->hw_fib;
> +#if 0	
>  	/*
>  	 * Set the status of this FIB to be Invalid parameter.
>  	 *
> @@ -788,6 +789,8 @@
>  	 */
>  	*(u32 *)hw_fib->data = cpu_to_le32(ST_OK);
>  	fib_adapter_complete(fibptr, sizeof(u32));
> +	/* This will be done on our return */
> +#endif
>  }
>  
>  /**
-- 
Mark Haverkamp <markh@osdl.org>

Re: PATCH: fix crashes with aacraid

[Alan Cox]

On Llu, 2005-01-03 at 17:05, Mark Haverkamp wrote:
> On Mon, 2004-12-27 at 14:43 +0000, Alan Cox wrote:
> > Is this change still needed for 2.6.10  Mark ?
> 
> I thought that the consensus was to remove aac_handle_aif altogether
> like the patch sent in by Tom Coughlan on Dec. 8th.

Thats what I assumed but then I could find nothing in 2.6.10 that made
aacraid work so I wasn't sure what if anything had been applied

Re: PATCH: fix crashes with aacraid

[Mark Haverkamp]

On Mon, 2005-01-03 at 18:43 +0000, Alan Cox wrote:
> On Llu, 2005-01-03 at 17:05, Mark Haverkamp wrote:
> > On Mon, 2004-12-27 at 14:43 +0000, Alan Cox wrote:
> > > Is this change still needed for 2.6.10  Mark ?
> > 
> > I thought that the consensus was to remove aac_handle_aif altogether
> > like the patch sent in by Tom Coughlan on Dec. 8th.
> 
> Thats what I assumed but then I could find nothing in 2.6.10 that made
> aacraid work so I wasn't sure what if anything had been applied

Yes, I looked and it hasn't been applied to either the scsi-misc-2.6 or
the scsi-rc-fixes-2.6 bk trees either.


-- 
Mark Haverkamp <markh@osdl.org>

Re: PATCH: fix crashes with aacraid

[James Bottomley]

On Mon, 2005-01-03 at 12:32 -0800, Mark Haverkamp wrote:
> Yes, I looked and it hasn't been applied to either the scsi-misc-2.6 or
> the scsi-rc-fixes-2.6 bk trees either.

Look, I'm really sorry but the dog got over excited on bonfire night and
knocked my crystal ball onto the floor and broke it.  So, until I can
get a new one on the National Elf Service, could you assume that if you
actually need me to apply a patch instead of getting it folded into an
aacraid update from you, you actually have to tell me this.

Thanks,

James

Re: PATCH: fix crashes with aacraid

[Mark Haverkamp]

On Mon, 2005-01-03 at 14:52 -0600, James Bottomley wrote:
> On Mon, 2005-01-03 at 12:32 -0800, Mark Haverkamp wrote:
> > Yes, I looked and it hasn't been applied to either the scsi-misc-2.6 or
> > the scsi-rc-fixes-2.6 bk trees either.
> 
> Look, I'm really sorry but the dog got over excited on bonfire night and
> knocked my crystal ball onto the floor and broke it.  So, until I can
> get a new one on the National Elf Service, could you assume that if you
> actually need me to apply a patch instead of getting it folded into an
> aacraid update from you, you actually have to tell me this.


Sorry, I didn't mean to imply anything on your part.  I had thought that
a patch had been submitted and may have just still been in the queue.

Sorry,
Mark.

(Tom, could you send the patch to James?)

-- 
Mark Haverkamp <markh@osdl.org>

Re: PATCH: fix crashes with aacraid

[James Bottomley]

On Mon, 2005-01-03 at 13:04 -0800, Mark Haverkamp wrote:
> Sorry, I didn't mean to imply anything on your part.  I had thought that
> a patch had been submitted and may have just still been in the queue.

That's OK.  I have the patch in the archives.  But usually if I see a
patch for a maintained driver go by, I wait to see what the maintainer
does with it.  Usually they either fold it into their own queue or tell
me to apply it.  If I hear nothing about it, I assume the former.

I'll dig the patch out and put it in the current tree.

James