From: James Bottomley <James.Bottomley@SteelEye.com>
To: tonyb@cybernetics.com
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix read capacity for large disks when CONFIG_LBD=n (updated)
Date: Tue, 04 Jan 2005 11:45:56 -0600 [thread overview]
Message-ID: <1104860756.5327.50.camel@mulgrave> (raw)
In-Reply-To: <05Jan4.115956est.332208@cyborg.cybernetics.com>
On Tue, 2005-01-04 at 11:59 -0500, Tony Battersby wrote:
> If CONFIG_LBD=n, then sd_read_capacity computes the capacity of a large
> disk on a 32-bit platform as 1 + 0xffffffff = 0. Make it 0xffffffff
> instead.
Actually, I don't think this is at all a good idea. Not allowing a LBD
device to be configured if the user hasn't enabled LBD (which is
accidentally what the current code does) seems better to me.
Imagine a 4TB fs. Plug it in to a system like this and you're going to
corrupt it because you can't see half the disc.
James
next prev parent reply other threads:[~2005-01-04 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 16:59 [PATCH] fix read capacity for large disks when CONFIG_LBD=n (updated) Tony Battersby
2005-01-04 17:45 ` James Bottomley [this message]
2005-01-04 17:56 ` [PATCH] fix read capacity for large disks when CONFIG_LBD=n(updated) Tony Battersby
2005-01-04 18:11 ` Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104860756.5327.50.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox