public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Scott M. Ferris" <sferris@acm.org>,
	Mike Christie <mikenc@us.ibm.com>,
	linux-iscsi-devel <linux-iscsi-devel@lists.sourceforge.net>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [linux-iscsi-devel] [question] deferred sense
Date: Wed, 05 Jan 2005 10:44:29 -0600	[thread overview]
Message-ID: <1104943469.3997.8.camel@mulgrave> (raw)
In-Reply-To: <20050105152333.GA1453@lst.de>

On Wed, 2005-01-05 at 16:23 +0100, Christoph Hellwig wrote:
> On Wed, Jan 05, 2005 at 09:21:12AM -0600, Scott M. Ferris wrote:
> > To be more specific, there were some devices that would fail a command
> > and return deferred sense.  The command didn't complete at the target,
> > and the kernel wasn't retrying it because the sense was deferred
> > rather than current.  For those devices, the translation produced the
> > desired retry.
> 
> Do you remember these devices?  Might be worth adding a midlayer
> blacklist entry for them.

That's certainly possible ... although we'd need a lot more details.
Any device that returns deferred sense for a current error is pretty
badly broken according to the spec.

> And I suspect we should get linux-scsi in the loop for the discussion
> about deferred sense handling.

Well, I'm willing to think about it again, but beyond reporting to the
user that "something went wrong" I'm not sure there's anything we can
do.

The most common case for deferred sense is using a writeback cache.
Here the device takes the write into its cache and returns GOOD.  Later
trying to write it to the device it gets a medium error and now tries to
send deferred sense saying "you remember that write I told you worked,
well actually..."  by this time, we've already acknowledged the write to
the block layer and any JFS will proceed on the assumption that it
completed.  There's no way we can go back in time and apply this error
to an already completed transaction.  However, the device has violated
the journalling assumptions, and the FS will be corrupt.

So does anyone have any better suggestions for handling deferred sense?

James



  reply	other threads:[~2005-01-05 16:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <41DB21D7.5080904@us.ibm.com>
     [not found] ` <20050104234700.GA18343@visi.com>
     [not found]   ` <20050105092144.GB26793@lst.de>
     [not found]     ` <20050105152112.GA8472@visi.com>
2005-01-05 15:23       ` [linux-iscsi-devel] [question] deferred sense Christoph Hellwig
2005-01-05 16:44         ` James Bottomley [this message]
2005-01-06 16:37           ` Tom Coughlan
2005-01-07  0:06             ` Douglas Gilbert
2005-01-11 11:44               ` Douglas Gilbert
2005-01-05 17:47 Salyzyn, Mark
2005-01-05 21:51 ` James Bottomley
2005-01-05 22:58   ` Matthew Wilcox
2005-01-06 23:09   ` Bryan Henderson
  -- strict thread matches above, loose matches on Subject: below --
2005-01-06 14:23 Salyzyn, Mark
2005-01-06 14:38 ` James Bottomley
2005-01-06 14:57 Salyzyn, Mark
2005-01-06 15:50 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1104943469.3997.8.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=hch@lst.de \
    --cc=linux-iscsi-devel@lists.sourceforge.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mikenc@us.ibm.com \
    --cc=sferris@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox