public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: grsec problem in scsi_ioctl
Date: Fri, 07 Jan 2005 15:54:24 -0500	[thread overview]
Message-ID: <1105131264.4151.19.camel@mulgrave> (raw)
In-Reply-To: <20050107194903.GB27371@parcelfarce.linux.theplanet.co.uk>

On Fri, 2005-01-07 at 19:49 +0000, Matthew Wilcox wrote:
> What a pleasant way to find out about a vulnerability ...
> 
> much snipped, I'm sure you can find the whole thing if you care to.

Not really .. the fix looks simple enough. I wonder what it would take
to train these people how actually to report a bug, sigh ...

James

===== drivers/block/scsi_ioctl.c 1.63 vs edited =====
--- 1.63/drivers/block/scsi_ioctl.c	2004-12-26 12:27:51 -05:00
+++ edited/drivers/block/scsi_ioctl.c	2005-01-07 15:46:36 -05:00
@@ -339,7 +339,8 @@
 			 struct gendisk *bd_disk, Scsi_Ioctl_Command __user *sic)
 {
 	struct request *rq;
-	int err, in_len, out_len, bytes, opcode, cmdlen;
+	int err;
+	unsigned int in_len, out_len, bytes, opcode, cmdlen;
 	char *buffer = NULL, sense[SCSI_SENSE_BUFFERSIZE];
 
 	/*



      reply	other threads:[~2005-01-07 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-07 19:49 grsec problem in scsi_ioctl Matthew Wilcox
2005-01-07 20:54 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1105131264.4151.19.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox