From: James Bottomley <James.Bottomley@SteelEye.com>
To: domen@coderock.org
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>, nacc@us.ibm.com
Subject: Re: [patch 4/7] scsi/qla_os: replace schedule_timeout() with ssleep()
Date: Wed, 12 Jan 2005 10:32:11 -0600 [thread overview]
Message-ID: <1105547532.5577.18.camel@mulgrave> (raw)
In-Reply-To: <20050111232257.909231F226@trashy.coderock.org>
On Wed, 2005-01-12 at 00:22 +0100, domen@coderock.org wrote:
> Description: Use ssleep() instead of schedule_timeout() to guarantee the
[...]
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(ABORT_POLLING_PERIOD);
> + msleep(ABORT_POLLING_PERIOD);
The description doesn't match the code.
Also, the qla driver is maintained. You should cc
andrew.vasquez@qlogic.com (I know they don't make it easy, like having
an entry in the MAINTAINERS file or even an email address in the code).
James
next prev parent reply other threads:[~2005-01-12 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 23:22 [patch 4/7] scsi/qla_os: replace schedule_timeout() with ssleep() domen
2005-01-12 16:32 ` James Bottomley [this message]
2005-01-12 23:43 ` Nishanth Aravamudan
2005-01-14 16:50 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105547532.5577.18.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=domen@coderock.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox