Re: [patch 4/7] scsi/qla_os: replace schedule_timeout() with ssleep()

[Andrew Vasquez <andrew.vasquez@qlogic.com>]

On Wed, 2005-01-12 at 15:43 -0800, Nishanth Aravamudan wrote:
> On Wed, Jan 12, 2005 at 10:32:11AM -0600, James Bottomley wrote:
> > On Wed, 2005-01-12 at 00:22 +0100, domen@coderock.org wrote:
> > > Description: Use ssleep() instead of schedule_timeout() to guarantee the
> > [...]
> > > -		set_current_state(TASK_UNINTERRUPTIBLE);
> > > -		schedule_timeout(ABORT_POLLING_PERIOD);
> > > +		msleep(ABORT_POLLING_PERIOD);
> > 
> > The description doesn't match the code.
> > 
> > Also, the qla driver is maintained.  You should cc
> > andrew.vasquez@qlogic.com (I know they don't make it easy, like having
> > an entry in the MAINTAINERS file or even an email address in the code).
> 
> Please find the corrected Description with this patch (and the appropriate CC).
> Thanks!
> 
> -Nish
> 
> Description: Use msleep() instead of schedule_timeout() to guarantee the
> task delays as expected. Change the values of the constants being used
> appropriately. I left the arithmetic there as it was before, even though
> it could be easily simplified away.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: Domen Puncer <domen@coderock.org>

ACK.

James, please add to your tree.

I'll forward over a diff to add an entry to the MAINTAINERS file in
another email.

Thanks,
Andrew Vasquez