From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andi Kleen <ak@muc.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Add compat_ioctl to scsi host structure
Date: Wed, 19 Jan 2005 07:55:01 -0800 [thread overview]
Message-ID: <1106150101.5150.1.camel@mulgrave> (raw)
In-Reply-To: <20050118232745.GA66256@muc.de>
On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote:
> On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote:
> > Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the
> > grounds that you never fill it in unless CONFIG_COMPAT is defined)?
>
> At least the standard file_operations has it without ifdef.
> I guess it doesn't hurt too much even on non compat systems.
Well, I wasn't really thinking of saving the four or eight bytes for the
pointer: It looks, from all the other patches, that the policy is that
any compat ioctl code should be surrounded by #ifdef CONFIG_COMPAT.
Thus, an easy way to enforce this policy is to do the same to the
structure definition, so the compiler will error if the driver writer
doesn't do it and tries to compile on a non-CONFIG_COMPAT platform.
James
next prev parent reply other threads:[~2005-01-19 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-18 11:03 [PATCH] Add compat_ioctl to scsi host structure Andi Kleen
2005-01-18 15:35 ` James Bottomley
2005-01-18 23:27 ` Andi Kleen
2005-01-19 15:55 ` James Bottomley [this message]
2005-01-19 16:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106150101.5150.1.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=ak@muc.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox