Re: [PATCH] Add compat_ioctl to scsi host structure

James Bottomley
2005-01-19T15:55:44Z

On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote:
> On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote:
> > Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the
> > grounds that you never fill it in unless CONFIG_COMPAT is defined)?
>
> At least the standard file_operations has it without ifdef.
> I guess it doesn't hurt too much even on non compat systems.

Well, I wasn't really thinking of saving the four or eight bytes for the
pointer: It looks, from all the other patches, that the policy is that
any compat ioctl code should be surrounded by #ifdef CONFIG_COMPAT.
Thus, an easy way to enforce this policy is to do the same to the
structure definition, so the compiler will error if the driver writer
doesn't do it and tries to compile on a non-CONFIG_COMPAT platform.

James