From: James Bottomley <James.Bottomley@SteelEye.com>
To: Heiko Carstens <Heiko.Carstens@de.ibm.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
willy@www.linux.org.uk
Subject: Re: [PATCH] zfcp: updates for -bk
Date: Mon, 24 Jan 2005 09:31:13 -0600 [thread overview]
Message-ID: <1106580673.5513.7.camel@mulgrave> (raw)
In-Reply-To: <OF78A719F0.8702D449-ONC1256F93.004FD89C-C1256F93.00516DAD@de.ibm.com>
On Mon, 2005-01-24 at 15:48 +0100, Heiko Carstens wrote:
> > I thought that having release methods that just called kfree() were
> > also verboten?
>
> We do a kmalloc(sizeof(struce device),...) somewhere and this
> is how we get rid of it again.
> How are we supposed to free this object otherwise? The release
> function gets called when there is no more reference to this
> object and that's the earliest point we may free it.
Right, but we've said before this is the wrong way to do it.
Originally this generic device was part of your adapter structure. Now
you're trying to separate it and causing these problems. What it's
apparently telling us is that you have some problem with the object
lifetime rules in your code.
Why should this generic_services device have different lifetime rules
from the object in which it used to reside?
James
next prev parent reply other threads:[~2005-01-24 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-24 9:46 [PATCH] zfcp: updates for -bk Heiko Carstens
2005-01-24 14:22 ` Matthew Wilcox
2005-01-24 14:48 ` Heiko Carstens
2005-01-24 15:31 ` James Bottomley [this message]
2005-01-25 6:08 ` Heiko Carstens
2005-01-25 15:20 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2005-01-25 18:10 Martin Peschke3
2005-01-25 18:40 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106580673.5513.7.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Heiko.Carstens@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@www.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox