Re: [PATCH 1/3] MidLayer updates - extending transport/attribute container changes

[James Bottomley <James.Bottomley@SteelEye.com>]

On Sat, 2005-01-29 at 09:03 -0500, James.Smart@Emulex.Com wrote:
>   Updates the recent transport container patch for :
>   - allow device driver-specific attributes to be added to class objects
>   - exposes classdev to transport via setup function

I'm not very keen on this for two reasons:

1) The driver should be tampering with class attributes.  A class and
its attributes are the presentation of an interface.  If the driver has
something more to add then surely that's an indication that the original
interface is missing pieces (i.e. every driver should have this) or that
the driver is trying to export a different interface (and so, logically
should use a new class.  i.e. just add a transport_class to the driver
and everything will work nicely).

2) classdevs are sysfs's representation of the interface.  I'd rather
they weren't exposed any more than necessary internally to avoid the
urge to hack the interface.

James