Re: [PATCH 3/3] MidLayer updates - extending scsi_target support

[James Bottomley <James.Bottomley@SteelEye.com>]

On Sat, 2005-01-29 at 09:03 -0500, James.Smart@Emulex.Com wrote:
>   This patch extends scsi_target support:
>   - Allows for driver-specific data to be allocated along with the
>     target structure and accessible via the starget->hostdata pointer.
>   - Adds scsi target alloc/configure/destory callbacks to the
>     scsi host template.
>   - Rearranges the calling sequences for scsi targets so that the
>     target and slave alloc/configure/destory callbacks are in
>     order (target before slave on alloc/configure).


the idea behind this is fine, I just don't like the interface.

Really a target device is nothing more than a container to SCSI.  We
already do the transport add/remove calls for targets, I don't see we
need other calls duplicating this.  So, I think the implementation would
look a whole lot better if the fc transport class just exported an
interface to get the extra storage for the driver and tacked it on to
its allocation.  Then you can use the existing mid-layer transport
target triggers to do everything you want.

James