From: James Bottomley <James.Bottomley@SteelEye.com>
To: Luben Tuikov <luben_tuikov@adaptec.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]
Date: Thu, 17 Feb 2005 14:57:04 -0600 [thread overview]
Message-ID: <1108673824.5507.32.camel@mulgrave> (raw)
In-Reply-To: <4214D5B1.1060701@adaptec.com>
On Thu, 2005-02-17 at 12:34 -0500, Luben Tuikov wrote:
> Adaptec would like to announce its SAS/SATA Linux device driver
> for inclusion into the Linux kernel.
Well, the initial reaction is yuk.
Just from a brief glance over the files, the code is full of obfuscation
and unnecessary compatibility gunk which needs removing.
It's also full of the same queueing junk that I asked be taken out of
the aic7xxx driver.
Then we get to the architectural stuff, which should really have been
discussed before you wrote the driver, not after
- We need a SAS and a PHY transport class. Three of your files are to
do domain discover and should actually be part of the SAS transport
class. In fact, it looks like a large amount of the code should be in
the various transport classes.
- The SATA pieces should use libata instead of trying to reinvent what
already exists.
James
next prev parent reply other threads:[~2005-02-17 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 17:34 [ANNOUNCE] Adaptec SAS/SATA device driver [0/27] Luben Tuikov
2005-02-17 19:38 ` Christoph Hellwig
2005-02-17 20:57 ` James Bottomley [this message]
2005-02-17 21:14 ` Luben Tuikov
2005-02-17 23:33 ` David Chaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1108673824.5507.32.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox