From: James Bottomley <James.Bottomley@SteelEye.com>
To: Yokota Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 9/13] nsp32, nsp_cs driver update
Date: Mon, 28 Feb 2005 19:10:12 +0200 [thread overview]
Message-ID: <1109610612.5330.2.camel@mulgrave> (raw)
In-Reply-To: <20050222.161158.59718314.yokota@netlab.is.tsukuba.ac.jp>
On Tue, 2005-02-22 at 16:11 +0900, Yokota Hiroshi wrote:
> + if (data->CurrentSC != NULL) {
> + nsp_msg(KERN_WARNING, "CurrentSC!=NULL this can't be happen");
> SCpnt->result = DID_BAD_TARGET << 16;
> nsp_scsi_done(SCpnt);
> - return 0;
> + return SCSI_MLQUEUE_HOST_BUSY;
> }
This looks wrong. Either you call done on the command or you return
busy. If you do both, the command will be completed twice. There seem
to be a lot of other places where the driver will call done then return
BUSY too ...
James
prev parent reply other threads:[~2005-02-28 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-22 7:11 [PATCH 9/13] nsp32, nsp_cs driver update Yokota Hiroshi
2005-02-28 17:10 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109610612.5330.2.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox