From: Willem Riede <osst@riede.org>
Cc: linux-scsi@vger.kernel.org, domen@coderock.org, nacc@us.ibm.com
Subject: Re: [patch 1/1] scsi/osst: replace schedule_timeout() with msleep()
Date: Sun, 06 Mar 2005 22:42:55 +0000 [thread overview]
Message-ID: <1110148975l.5880l.4l@serve.riede.org> (raw)
In-Reply-To: <20050306222742.294F71EC90@trashy.coderock.org> (from domen@coderock.org on Sun Mar 6 17:27:41 2005)
On 03/06/2005 05:27:41 PM, domen@coderock.org wrote:
>
>
> Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. Although TASK_INTERRUPTIBLE is used in the current code,
> there is no code dealing with an early return / signals_pending().
This change is a total don't-care as far as I'm concerned. But if we are going to
make it, can we please be consistent? Does the "set_current_state(TASK_INTERRUPTIBLE)"
stay or go? The two changes below don't agree in that respect.
---
> attempts--;
> - set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(HZ / 10);
> + msleep(100);
> }
---
> #endif
> set_current_state(TASK_INTERRUPTIBLE);
> - schedule_timeout(HZ / 10);
> + msleep(100);
> }
---
Regards, Willem Riede,
osst maintainer.
next prev parent reply other threads:[~2005-03-06 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:27 [patch 1/1] scsi/osst: replace schedule_timeout() with msleep() domen
2005-03-06 22:42 ` Willem Riede [this message]
2005-03-07 23:05 ` [UPDATE PATCH] " Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110148975l.5880l.4l@serve.riede.org \
--to=osst@riede.org \
--cc=domen@coderock.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox