* PATCH: atp870u DMA mask
@ 2005-03-11 14:17 Alan Cox
2005-03-11 14:40 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2005-03-11 14:17 UTC (permalink / raw)
To: torvalds, linux-scsi
Noted by James Bottomley
Signed-off-by: Alan Cox <alan@redhat.com>
--- drivers/scsi/atp870u.c.old 2005-03-11 14:14:53.015465656 +0000
+++ drivers/scsi/atp870u.c 2005-03-11 14:15:24.950610776 +0000
@@ -2634,7 +2634,7 @@
if (pci_enable_device(pdev))
return -EIO;
- if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
+ if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {
printk(KERN_INFO "atp870u: use 32bit DMA mask.\n");
} else {
printk(KERN_ERR "atp870u: DMA mask required but not available.\n");
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: PATCH: atp870u DMA mask
2005-03-11 14:17 PATCH: atp870u DMA mask Alan Cox
@ 2005-03-11 14:40 ` Arjan van de Ven
2005-03-11 14:46 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Arjan van de Ven @ 2005-03-11 14:40 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-scsi
On Fri, 2005-03-11 at 14:17 +0000, Alan Cox wrote:
> Noted by James Bottomley
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> --- drivers/scsi/atp870u.c.old 2005-03-11 14:14:53.015465656 +0000
> +++ drivers/scsi/atp870u.c 2005-03-11 14:15:24.950610776 +0000
> @@ -2634,7 +2634,7 @@
> if (pci_enable_device(pdev))
> return -EIO;
>
> - if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
> + if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {
isn't it still an F short?
And... why not use the DMA_32_BIT or whatever define.. it's there for
exactly this reason :)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: PATCH: atp870u DMA mask
2005-03-11 14:40 ` Arjan van de Ven
@ 2005-03-11 14:46 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2005-03-11 14:46 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-scsi
On Gwe, 2005-03-11 at 14:40, Arjan van de Ven wrote:
> > - if (!pci_set_dma_mask(pdev, 0xFFFFFFUL)) {
> > + if (!pci_set_dma_mask(pdev, 0xFFFFFFFFUL)) {
> isn't it still an F short?
> And... why not use the DMA_32_BIT or whatever define.. it's there for
> exactly this reason :)
No its 32bit not 36bit DMA capable. As to DMA_32_BIT - I didn't know
about it, I'll go take a look for some examples.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-11 14:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-11 14:17 PATCH: atp870u DMA mask Alan Cox
2005-03-11 14:40 ` Arjan van de Ven
2005-03-11 14:46 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox