From: James Bottomley <James.Bottomley@SteelEye.com>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Greg KH <greg@kroah.com>, Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes
Date: Thu, 17 Mar 2005 09:53:21 -0500 [thread overview]
Message-ID: <1111071201.5994.4.camel@mulgrave> (raw)
In-Reply-To: <20050316224551.GA21918@us.ibm.com>
On Wed, 2005-03-16 at 14:45 -0800, Patrick Mansfield wrote:
> Any comments on this? Should I resend these patches?
Well, the basic comment is that there are a lot of features that SCSI
has that the driver core lacks:
1) Attribute overrides. This is actually part of the published API for
SCSI
2) Ability to add extra attributes---several drivers use this
3) Ability to change attribute permissions based on capabilities.
I really rather like all of these features.
Initially when we did all this work for SCSI, there wasn't much
enthusiasm for incorporating these features into drivers/base. You
could look and see what it would take to do this, and propose it to
Greg ... If he's happy, I'd have no problem moving over because now we
won't lose any functionality.
James
next prev parent reply other threads:[~2005-03-17 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-02 19:44 [PATCH] 0/2 use sysfs bus dev_attrs for scsi_device attributes Patrick Mansfield
2005-03-02 19:45 ` [PATCH] 1/2 remove attr_changed_internally Patrick Mansfield
2005-03-02 19:46 ` [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes Patrick Mansfield
2005-03-16 22:45 ` Patrick Mansfield
2005-03-17 14:53 ` James Bottomley [this message]
2005-03-17 17:08 ` Greg KH
2005-03-30 3:15 ` Kay Sievers
2005-03-30 4:20 ` Greg KH
2005-03-30 18:07 ` Kay Sievers
2005-04-06 20:22 ` Greg KH
2005-03-30 18:32 ` Kay Sievers
2005-03-30 21:44 ` Patrick Mansfield
2005-03-30 22:12 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111071201.5994.4.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox