From: James Bottomley <James.Bottomley@SteelEye.com>
To: Matthew Wilcox <willy@parisc-linux.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] [4/5] ncr53c8xx update
Date: Sat, 19 Mar 2005 18:32:07 -0600 [thread overview]
Message-ID: <1111278727.5525.33.camel@mulgrave> (raw)
In-Reply-To: <20050319035637.16128496108@palinux.hppa>
On Fri, 2005-03-18 at 20:56 -0700, Matthew Wilcox wrote:
> ncr53c8xx update
There's actually a slight problem with this one: on my Q720 it produces
messages like this:
ncr53c720-1: ID 7, Fast-10, Parity Checking
scsi1 : ncr53c8xx-3.4.3g
target1:0:1: target did not report SYNC.
Vendor: TOSHIBA Model: CD-ROM XM-5401TA Rev: 3605
Type: CD-ROM ANSI SCSI revision: 02
target1:0:1: Beginning Domain Validation
target1:0:1: asynchronous.
target1:0:1: Domain Validation skipping write tests
target1:0:1: FAST-5 SCSI 4.2 MB/s ST (236 ns, offset 8)
target1:0:1: Ending Domain Validation
Although everything is fine. The initial "target did not report SYNC"
is because the driver is trying to negotiate over the initial inquiry
(so, naturally we don't know if it supports sync yet). The solution is
to rip out the last remnants of the spontaneous attempts at negotiation
to force it to wait for the DV negotiation in slave_configure.
James
===== drivers/scsi/ncr53c8xx.c 1.53 vs edited =====
--- 1.53/drivers/scsi/ncr53c8xx.c 2005-03-18 21:36:11 -06:00
+++ edited/drivers/scsi/ncr53c8xx.c 2005-03-19 17:57:28 -06:00
@@ -3278,6 +3278,7 @@
tp->usrsync = driver_setup.default_sync;
tp->usrwide = driver_setup.max_wide;
tp->usrtags = MAX_TAGS;
+ tp->period = 0xffff;
if (!driver_setup.disconnection)
np->target[i].usrflag = UF_NODISC;
}
@@ -4650,7 +4651,6 @@
if (tp->usrwide > np->maxwide)
tp->usrwide = np->maxwide;
- ncr_negotiate (np, tp);
}
/*
@@ -6900,15 +6900,10 @@
unsigned char tn = sdev->id, ln = sdev->lun;
struct tcb *tp = &np->target[tn];
struct lcb *lp = tp->lp[ln];
- struct scsi_target *starget = sdev->sdev_target;
/* If no lcb, try to allocate it. */
if (!lp && !(lp = ncr_alloc_lcb(np, tn, ln)))
goto fail;
-
- /* Prepare negotiation */
- if (spi_support_wide(starget) || spi_support_sync(starget))
- ncr_negotiate(np, tp);
/*
** If unit supports tagged commands, allocate the
next prev parent reply other threads:[~2005-03-20 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 3:56 [PATCH] [4/5] ncr53c8xx update Matthew Wilcox
2005-03-20 0:32 ` James Bottomley [this message]
2005-03-20 1:32 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111278727.5525.33.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox