From: Willem Riede <osst@riede.org>
To: James.Bottomley@SteelEye.com, Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
osst-users@lists.sourceforge.net, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/scsi/osst.c: make code static
Date: Tue, 22 Mar 2005 21:19:52 +0000 [thread overview]
Message-ID: <1111526392l.12349l.36l@serve.riede.org> (raw)
In-Reply-To: <20050322142806.GR3982@stusta.de> (from bunk@stusta.de on Tue Mar 22 09:28:07 2005)
On 03/22/2005 09:28:07 AM, Adrian Bunk wrote:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
James, I agree with this, can you put it in BK, please?
Signed-off-by: Willem Riede <osst@riede.org>
> ---
>
> This patch was already sent on:
> - 28 Feb 2005
>
> drivers/scsi/osst.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c.old 2005-02-28 19:36:05.000000000 +0100
> +++ linux-2.6.11-rc4-mm1-full/drivers/scsi/osst.c 2005-02-28 19:36:25.000000000 +0100
> @@ -24,7 +24,7 @@
> */
>
> static const char * cvsid = "$Id: osst.c,v 1.73 2005/01/01 21:13:34 wriede Exp $";
> -const char * osst_version = "0.99.3";
> +static const char * osst_version = "0.99.3";
>
> /* The "failure to reconnect" firmware bug */
> #define OSST_FW_NEED_POLL_MIN 10601 /*(107A)*/
> @@ -170,7 +170,7 @@
> static int osst_probe(struct device *);
> static int osst_remove(struct device *);
>
> -struct scsi_driver osst_template = {
> +static struct scsi_driver osst_template = {
> .owner = THIS_MODULE,
> .gendrv = {
> .name = "osst",
>
next prev parent reply other threads:[~2005-03-22 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 14:28 [2.6 patch] drivers/scsi/osst.c: make code static Adrian Bunk
2005-03-22 21:19 ` Willem Riede [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-28 20:56 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111526392l.12349l.36l@serve.riede.org \
--to=osst@riede.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osst-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox