From: Willem Riede <osst@riede.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: osst-users@lists.sourceforge.net, James.Bottomley@SteelEye.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/scsi/osst.c: remove unused code
Date: Wed, 23 Mar 2005 12:16:54 +0000 [thread overview]
Message-ID: <1111580214l.12349l.37l@serve.riede.org> (raw)
In-Reply-To: <20050322215948.GP1948@stusta.de> (from bunk@stusta.de on Tue Mar 22 16:59:48 2005)
On 03/22/2005 04:59:48 PM, Adrian Bunk wrote:
> Thanks to both the Coverity checker and GNU gcc, it was found that this
> variable is completely unused.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
And it is so obvious when your attention is drawn to it.
The code that did use it moved to os_scsi_tape_flush() recently.
James, could you make this change in BK too, please?
Signed-off-by: Willem Riede <osst@riede.org>
> --- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 21:04:36.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c 2005-03-22 22:09:32.000000000 +0100
> @@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
> {
> int result = 0;
> struct osst_tape * STp = filp->private_data;
> - struct scsi_request * SRpnt = NULL;
> -
> - if (SRpnt) scsi_release_request(SRpnt);
>
> if (STp->door_locked == ST_LOCKED_AUTO)
> do_door_lock(STp, 0);
>
prev parent reply other threads:[~2005-03-23 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-22 21:59 [2.6 patch] drivers/scsi/osst.c: remove unused code Adrian Bunk
2005-03-23 12:16 ` Willem Riede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111580214l.12349l.37l@serve.riede.org \
--to=osst@riede.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osst-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox