From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] 2.6 aacraid: endian cleanup Date: Mon, 28 Mar 2005 15:58:48 -0600 Message-ID: <1112047128.5531.78.camel@mulgrave> References: <1111430484.9918.9.camel@markh1.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from stat16.steeleye.com ([209.192.50.48]:7638 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S262091AbVC1V67 (ORCPT ); Mon, 28 Mar 2005 16:58:59 -0500 In-Reply-To: <1111430484.9918.9.camel@markh1.pdx.osdl.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Mark Haverkamp Cc: linux-scsi , Mark Salyzyn On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote: > + Adaptec 2130S Why are we getting updated card support in an endian cleanup patch? > +/* > + * Some configurations of BE Linux have writel and readl automatically perform > + * byte swapping, and some configurations (embedded) do not. Typically > + * AAC_IO_USES_CPU_ORDER needs to be defined since most BE ports are working > + * with drivers that have not been coded to support BE. > + */ > +#define AAC_IO_USES_CPU_ORDER 1 > +#ifdef AAC_IO_USES_CPU_ORDER > +# define aac_io_le32_to_cpu > +# define aac_io_cpu_to_le16 > +# define aac_io_cpu_to_le32 > +#else > +# define aac_io_le32_to_cpu le32_to_cpu > +# define aac_io_cpu_to_le16 cpu_to_le16 > +# define aac_io_cpu_to_le32 cpu_to_le32 > +#endif What exactly is this for? I know of no platforms that implement readl and friends incorrectly, so all of this should be unnecessary. James