From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: "David S. Miller" <davem@davemloft.net>,
matthew@wil.cx, SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: iomapping a big endian area
Date: Mon, 04 Apr 2005 17:50:39 +1000 [thread overview]
Message-ID: <1112601039.26086.49.camel@gaston> (raw)
In-Reply-To: <1112502477.5786.38.camel@mulgrave>
On Sat, 2005-04-02 at 22:27 -0600, James Bottomley wrote:
> On Sat, 2005-04-02 at 20:08 -0800, David S. Miller wrote:
> > > Did anyone have a preference for the API? I was thinking
> > > ioread32_native, but ioread32be is fine too.
> >
> > I think doing foo{be,le}{8,16,32}() would be consistent with
> > our byteorder.h interface names.
>
> Thinking about this some more, I know of no case of a BE bus connected
> to a LE system, nor do I think anyone would ever create such a beast, so
> our only missing interface is for a BE bus on a BE system.
It's more a matter of the device than the bus imho...
> Thus, I think io{read,write}{16,32}_native are better interfaces ...
I disagree. The driver will never "know" ...
> they basically mean pass memory operations without byte swaps, so
> they're well defined on both BE and LE systems and correspond exactly to
> our existing _raw_{read,write}{w,l} calls (principle of least surprise).
I don't think it's sane. You know that your device is BE or LE and use
the appropriate interface. "native" doesn't make sense to me in this
context.
Ben.
next prev parent reply other threads:[~2005-04-04 7:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-02 20:52 [PATCH] finally fix 53c700 to use the generic iomem infrastructure James Bottomley
2005-04-03 1:37 ` iomapping a big endian area Matthew Wilcox
2005-04-03 2:38 ` David S. Miller
2005-04-03 3:10 ` Matthew Wilcox
2005-04-03 3:40 ` James Bottomley
2005-04-03 4:08 ` David S. Miller
2005-04-03 4:27 ` James Bottomley
2005-04-04 7:50 ` Benjamin Herrenschmidt [this message]
2005-04-04 13:59 ` James Bottomley
2005-04-04 14:16 ` Christoph Hellwig
2005-04-04 14:25 ` James Bottomley
2005-04-07 23:57 ` Jesse Barnes
2005-04-04 14:22 ` Randy.Dunlap
2005-04-04 23:41 ` Benjamin Herrenschmidt
2005-04-04 23:43 ` Benjamin Herrenschmidt
2005-04-04 7:49 ` Benjamin Herrenschmidt
2005-04-05 7:42 ` Russell King
2005-04-05 14:05 ` James Bottomley
2005-04-05 18:55 ` Russell King
2005-04-05 20:02 ` Maciej W. Rozycki
2005-04-04 21:17 ` James Bottomley
2005-04-05 7:21 ` Christoph Hellwig
2005-04-05 14:05 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112601039.26086.49.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=James.Bottomley@SteelEye.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox