From: Dmitry Yusupov <dima@neterion.com>
To: Greg KH <greg@kroah.com>
Cc: Alex Aizman <itn780@yahoo.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator
Date: Tue, 12 Apr 2005 09:34:33 -0700 [thread overview]
Message-ID: <1113323674.10545.5.camel@beastie> (raw)
In-Reply-To: <20050412053532.GE32372@kroah.com>
On Mon, 2005-04-11 at 22:35 -0700, Greg KH wrote:
> On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote:
> > +typedef uint64_t iscsi_snx_t; /* iSCSI Data-Path session handle */
> > +typedef uint64_t iscsi_cnx_t; /* iSCSI Data-Path connection handle */
>
> Do you really have to create a new typedef? Please reconsider. Just
> use u64 everywhere, unless you need to do type checking...
it is a handle and it is used as a parameter in exported API. yes. type
checking exactly the reason.
Dima
next prev parent reply other threads:[~2005-04-12 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 3:24 [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator Alex Aizman
2005-04-12 5:34 ` Greg KH
2005-04-12 5:35 ` Greg KH
2005-04-12 16:34 ` Dmitry Yusupov [this message]
2005-04-12 5:36 ` Greg KH
2005-04-12 7:27 ` Christoph Hellwig
2005-04-12 7:45 ` Greg KH
2005-04-12 8:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113323674.10545.5.camel@beastie \
--to=dima@neterion.com \
--cc=greg@kroah.com \
--cc=itn780@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox