From: James Bottomley <James.Bottomley@SteelEye.com>
To: Masao Fukuchi <fukuchi.masao@jp.fujitsu.com>
Cc: "Moore, Eric Dean" <Eric.Moore@lsil.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: Question about scsi_device_online() usage in mptscsih
Date: Fri, 15 Apr 2005 09:30:26 -0500 [thread overview]
Message-ID: <1113575426.5009.11.camel@mulgrave> (raw)
In-Reply-To: <200504151013.AA04188@fukuchi.jp.fujitsu.com>
On Fri, 2005-04-15 at 19:13 +0900, Masao Fukuchi wrote:
> The sequence is:
> 1.Host issues SCSI command to fusion MPT driver.
> 2.Mid layer detects command timeout and then performs
> error recovery sequence.
> But the sequence fails and it causes device offline.
> (fusion MPT driver still hold the command)
> 4.Fusion MPT driver activates host reset and calls
> mptscsih_flush_running_cmds().
Well, this is the error: The Fusion host reset should be activated from
the eh_host_reset_handler.
> 5.In mptscsih_flush_running_cmds(), pci_unmap_sg() is called
> for all SCSI cmds.
> But the buffer had already freed and this causes oops.
If you do the above, the command will still be valid. If you wait until
after the device is offlined, of course the mid-layer throws away the
commands, since it's up to the driver to clean them up during the reset
sequences.
James
next prev parent reply other threads:[~2005-04-15 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 20:28 Question about scsi_device_online() usage in mptscsih Moore, Eric Dean
2005-04-15 10:13 ` Masao Fukuchi
2005-04-15 14:30 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-15 16:11 Moore, Eric Dean
2005-04-15 16:41 ` James Bottomley
2005-04-02 5:35 Tejun Heo
2005-04-14 18:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113575426.5009.11.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Eric.Moore@lsil.com \
--cc=fukuchi.masao@jp.fujitsu.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox