From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: PATCH [2/5] qla2xxx: add remote port codes...
Date: Sun, 17 Apr 2005 10:18:21 -0500 [thread overview]
Message-ID: <1113751101.5011.5.camel@mulgrave> (raw)
In-Reply-To: <20050413191824.GK9703@plap.qlogic.org>
On Wed, 2005-04-13 at 12:18 -0700, Andrew Vasquez wrote:
> drivers/scsi/qla2xxx/qla_attr.c | 323 ++++++++++++++++++++++++++++++++++++++++
This file uses vmalloc but doesn't appear to include linux/vmalloc.h
causing a compiler warning in my build env. It also includes
linux/version.h, which it doesn't appear to need.
I'll stick this patch in to correct the problem.
James
===== drivers/scsi/qla2xxx/qla_attr.c 1.2 vs edited =====
--- 1.2/drivers/scsi/qla2xxx/qla_attr.c 2005-04-13 10:45:53 -05:00
+++ edited/drivers/scsi/qla2xxx/qla_attr.c 2005-04-17 09:41:13 -05:00
@@ -18,7 +18,7 @@
*/
#include "qla_def.h"
-#include <linux/version.h>
+#include <linux/vmalloc.h>
#include <scsi/scsi_transport_fc.h>
/* SYSFS attributes --------------------------------------------------------- */
next prev parent reply other threads:[~2005-04-17 15:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 19:15 PATCH [0/5] qla2xxx: remote port rework Andrew Vasquez
2005-04-13 19:18 ` PATCH [1/5] qla2xxx: remove internal queuing Andrew Vasquez
2005-04-13 19:18 ` PATCH [2/5] qla2xxx: add remote port codes Andrew Vasquez
2005-04-13 21:40 ` Christoph Hellwig
2005-04-19 6:33 ` Andrew Vasquez
2005-04-19 7:27 ` Andrew Vasquez
2005-04-19 21:13 ` Christoph Hellwig
2005-05-20 6:17 ` Jeremy Higdon
2005-05-20 15:15 ` Andrew Vasquez
2005-05-27 7:51 ` Jeremy Higdon
2005-04-17 15:18 ` James Bottomley [this message]
2005-04-13 19:18 ` PATCH [3/5] qla2xxx: remove lun discovery codes Andrew Vasquez
2005-04-13 19:19 ` PATCH [4/5] qla2xxx: cleanup DMA mappings Andrew Vasquez
2005-04-13 21:34 ` Christoph Hellwig
2005-04-15 18:06 ` Andrew Vasquez
2005-04-13 19:19 ` PATCH [5/5] qla2xxx: remove /proc interface Andrew Vasquez
2005-04-13 19:42 ` PATCH [0/5] qla2xxx: remote port rework Matthew Wilcox
2005-04-13 20:50 ` PATCH [6/5] qla2xxx: update version :) Andrew Vasquez
2005-04-13 20:57 ` James Bottomley
2005-04-13 21:24 ` Andrew Vasquez
2005-04-19 21:15 ` Christoph Hellwig
2005-04-22 7:22 ` Andrew Vasquez
2005-04-24 10:53 ` Christoph Hellwig
2005-04-13 21:17 ` Christoph Hellwig
2005-04-15 17:38 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113751101.5011.5.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox