* [PATCH] correct the sym2 period setting routines
@ 2005-05-06 18:14 James Bottomley
0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2005-05-06 18:14 UTC (permalink / raw)
To: willy; +Cc: SCSI Mailing List
There's a slight bug in the routines in that if the period requires dt,
then the routine will unconditionally set it. DT may only be set if
Wide is also set, so this turns back on the wide bit.
For domain validation to work correctly, we need to observe the wide bit
absolutely.
James
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
@@ -2038,8 +2038,9 @@ static void sym2_set_period(struct scsi_
struct sym_hcb *np = sym_get_hcb(shost);
struct sym_tcb *tp = &np->target[starget->id];
- /* have to have DT for these transfers */
- if (period <= np->minsync)
+ /* have to have DT for these transfers, but DT will also
+ * set width, so check that this is allowed */
+ if (period <= np->minsync && spi_width(starget))
tp->tgoal.dt = 1;
tp->tgoal.period = period;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-05-06 18:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-06 18:14 [PATCH] correct the sym2 period setting routines James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox