From: James Bottomley <James.Bottomley@SteelEye.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jens Axboe <axboe@suse.de>, Christoph Hellwig <hch@infradead.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH scsi-misc-2.6 04/04] scsi: remove unnecessary scsi_wait_req_end_io()
Date: Mon, 16 May 2005 11:07:32 -0500 [thread overview]
Message-ID: <1116259652.5040.17.camel@mulgrave> (raw)
In-Reply-To: <20050515011532.GA26421@htj.dyndns.org>
On Sun, 2005-05-15 at 10:15 +0900, Tejun Heo wrote:
> I've made two new versions of the same patch. The first one just
> BUG() such cases, and the second one makes scsi_prep_fn() tell
> scsi_request_fn() to kill requests instead of doing itself w/
> BLKPREP_KILL. In both cases, I made req->flags error case a BUG().
> If you don't like it, feel free to drop that part.
>
> Oh... one more thing. I forgot to mention the scsi_kill_requests()
> path. As it's a temporary fix, I just left it as it is (terminate
> commands w/ end_that_*). I guess this patch should be pushed after
> removal of that kludge. But with or without this patch, that path
> will leak resources.
I suppose it's not surprising that I don't like either.
You remove the code that handles the BLKPREP_KILL case and then contort
the request functions to try not to do it. We have to handle this case,
it's not optional, so just leave the code that does it in.
James
next prev parent reply other threads:[~2005-05-16 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-14 13:57 [PATCH scsi-misc-2.6 00/04] scsi: scsi_request_fn() reimplementation Tejun Heo
2005-05-14 13:57 ` [PATCH scsi-misc-2.6 01/04] scsi: consolidate error handling out of scsi_init_io() into scsi_prep_fn() Tejun Heo
2005-05-14 13:57 ` [PATCH scsi-misc-2.6 02/04] scsi: move request preps in other places into prep_fn() Tejun Heo
2005-05-14 13:57 ` [PATCH scsi-misc-2.6 03/04] scsi: reimplement scsi_request_fn() Tejun Heo
2005-05-14 13:57 ` [PATCH scsi-misc-2.6 04/04] scsi: remove unnecessary scsi_wait_req_end_io() Tejun Heo
2005-05-14 15:26 ` James Bottomley
2005-05-14 15:47 ` Tejun Heo
2005-05-14 16:19 ` James Bottomley
2005-05-15 1:15 ` Tejun Heo
2005-05-16 16:07 ` James Bottomley [this message]
2005-05-16 16:56 ` Tejun Heo
2005-05-15 1:16 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2005-04-12 10:32 [PATCH scsi-misc-2.6 00/04] scsi: scsi_request_fn() reimplementation Tejun Heo
2005-04-12 10:33 ` [PATCH scsi-misc-2.6 04/04] scsi: remove unnecessary scsi_wait_req_end_io() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116259652.5040.17.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox