Re: [gregoire.favre@gmail.com: What breaks aic7xxx in post 2.6.12-rc2 ?]

[James Bottomley <James.Bottomley@SteelEye.com>]

On Mon, 2005-05-16 at 17:54 +0200, Grégoire Favre wrote:
> What's DV ?

Domain Validation ... it's a way of probing the SCSI bus to check that
the transport parameters for the device are correct (and that nothing on
the bus is interfering with the transmissions).

> Host: scsi1 Channel: 00 Id: 01 Lun: 00
>   Vendor: TOSHIBA  Model: DVD-ROM SD-M1201 Rev: 1R08
>   Type:   CD-ROM                           ANSI SCSI revision: 02

Aha, this wouldn't be the first DVD to screw up in domain validation.
The first such problem was because the device lied about having an echo
buffer ... I suspect that may be the case here too.

The initial fix was just to disbelieve the device if it didn't support
ppr.  Could you try the attached?  It expands the check to disbelieve
the return for all CD type devices.

Thanks,

James

--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -799,7 +799,7 @@ spi_dv_device_internal(struct scsi_reque
 	 * do the SPI pattern write tests */
 
 	len = 0;
-	if (sdev->ppr)
+	if (sdev->ppr && sdev->type != TYPE_ROM)
 		len = spi_dv_device_get_echo_buffer(sreq, buffer);
 
  retry:


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html