Re: TYPE_RBC cache fixes (sbp2.c affected)

James Bottomley
2005-05-21T15:01:54Z

On Mon, 2005-05-16 at 02:59 +0100, Al Viro wrote:

> static int sbp2scsi_slave_configure (struct scsi_device *sdev)
> {
> blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
> -
> + sdev->use_10_for_rw = 1;
> + sdev->use_10_for_ms = 1;
> return 0;
> }

This looks wrong. The RBC standard only specifies the six byte commands
to be mandatory ... so shouldn't this be sdev->use_10_for_ms = 0?

James