Re: TYPE_RBC cache fixes (sbp2.c affected)

Douglas Gilbert
2005-05-21T22:06:51Z

James Bottomley wrote:
> On Sat, 2005-05-21 at 17:22 +0100, Al Viro wrote:
>
>>Tell that to firmware authors, why don't you?
>
>
> I do ... but they don't listen ...
>
>
>>>Does anyone actually have one of these RBC devices and does it reject
>>>the six byte mode sense commands?
>>
>>Yes, will check and do not expect the results to apply to other devices...
>
>
> Thanks ... I'd be surprised if the entire class of RBC devices simply
> ignored the standard; I wouldn't be surprised to find one or two that
> are out of spec.
>
> James
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

James,
Perhaps __scsi_mode_sense() could do a simple sanity
check: for any valid mode page [after the header and
block descriptor(s) are stepped over]:
((mpage[0] & 3f) == page_num)

If a response fails that test, we don't believe it.

Doug Gilbert