Re: TYPE_RBC cache fixes (sbp2.c affected)

James Bottomley
2005-05-21T16:01:21Z

On Sat, 2005-05-21 at 11:38 -0400, Jeff Garzik wrote:
> That's why its in sbp2-specific code...
>
> The above code certainly applies to real-world cases, at least. Just
> look at the code that was removed... MS(10) handling.

I know that; and I know it has the effect of the replaced code.
However, I don't understand why SBC2 feels entitled to ignore the RBC
standard here ... that standard was primarily created for SBC2 devices.

So was the code in sbc2 because non-RBC devices needed the 10 byte
command and RBC ones just happened not to reject it? My sense here is
that we should have code in scsi_scan.c to set sdev->use_10_for_rw and
reset sdev->use_10_for_ms before the slave configure predicated on
TYPE_RBC.

Does anyone actually have one of these RBC devices and does it reject
the six byte mode sense commands?

James