From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
linux1394-devel@lists.sourceforge.net
Subject: Re: TYPE_RBC cache fixes (sbp2.c affected)
Date: Sat, 21 May 2005 11:00:56 -0500 [thread overview]
Message-ID: <1116691256.4999.16.camel@mulgrave> (raw)
In-Reply-To: <428F55F1.3090006@pobox.com>
On Sat, 2005-05-21 at 11:38 -0400, Jeff Garzik wrote:
> That's why its in sbp2-specific code...
>
> The above code certainly applies to real-world cases, at least. Just
> look at the code that was removed... MS(10) handling.
I know that; and I know it has the effect of the replaced code.
However, I don't understand why SBC2 feels entitled to ignore the RBC
standard here ... that standard was primarily created for SBC2 devices.
So was the code in sbc2 because non-RBC devices needed the 10 byte
command and RBC ones just happened not to reject it? My sense here is
that we should have code in scsi_scan.c to set sdev->use_10_for_rw and
reset sdev->use_10_for_ms before the slave configure predicated on
TYPE_RBC.
Does anyone actually have one of these RBC devices and does it reject
the six byte mode sense commands?
James
next prev parent reply other threads:[~2005-05-21 16:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 1:59 TYPE_RBC cache fixes (sbp2.c affected) Al Viro
2005-05-16 3:26 ` Douglas Gilbert
2005-05-16 4:18 ` Al Viro
2005-05-21 5:03 ` Douglas Gilbert
2005-05-21 15:01 ` James Bottomley
2005-05-21 15:38 ` Jeff Garzik
2005-05-21 16:00 ` James Bottomley [this message]
2005-05-21 16:22 ` Al Viro
2005-05-21 18:12 ` James Bottomley
2005-05-21 22:06 ` Douglas Gilbert
2005-05-22 5:08 ` Douglas Gilbert
2005-05-21 15:24 ` James Bottomley
2005-05-22 10:15 ` Douglas Gilbert
2005-05-22 6:31 ` Douglas Gilbert
2005-05-22 14:06 ` James Bottomley
2005-05-23 15:14 ` Douglas Gilbert
2006-02-08 23:39 ` Stefan Richter
2006-02-08 23:54 ` Al Viro
2006-02-11 9:50 ` Stefan Richter
2006-02-11 13:05 ` Al Viro
2006-02-13 20:40 ` Stefan Richter
2006-02-20 6:08 ` Al Viro
2006-02-21 19:56 ` Stefan Richter
2006-02-21 21:51 ` Al Viro
2006-02-21 22:41 ` Stefan Richter
2006-02-22 7:08 ` Stefan Richter
2006-02-22 7:16 ` Al Viro
2006-02-22 7:35 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116691256.4999.16.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox