From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] qla2xxx: fix bad locking during eh_abort
Date: Fri, 27 May 2005 16:06:11 -0400 [thread overview]
Message-ID: <1117224371.7379.21.camel@mulgrave> (raw)
In-Reply-To: <20050526231938.GA31205@plap.qlogic.org>
On Thu, 2005-05-26 at 16:19 -0700, Andrew Vasquez wrote:
> Please apply, this should go in before 2.6.12 is released.
I've got it in the rc-fixes tree for scsi. However:
> + spin_unlock(&ha->hardware_lock);
Should be spin_unlock_irq(&ha->hardware_lock); shouldn't it? Otherwise
we could sleep with interrupts disabled and the kernel now squeaks about
that.
James
next prev parent reply other threads:[~2005-05-27 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 23:19 [PATCH] qla2xxx: fix bad locking during eh_abort Andrew Vasquez
2005-05-27 20:06 ` James Bottomley [this message]
2005-05-27 20:18 ` Andrew Vasquez
2005-05-27 20:30 ` Jeff Garzik
2005-05-27 20:38 ` James Bottomley
2005-05-27 20:42 ` Jeff Garzik
2005-05-27 22:04 ` Andrew Vasquez
2005-05-27 22:47 ` Jeff Garzik
2005-05-27 20:31 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117224371.7379.21.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox