Re: [PATCH 1/4] fusion - sas support

[James Bottomley <James.Bottomley@SteelEye.com>]

On Wed, 2005-06-01 at 10:47 -0600, Moore, Eric Dean wrote:
> Changelog:
> * adding support for new module in Kconfig and Makefile
> * adding mptsas.c module 

No to this one until you and Adaptec (and any other interested parties)
get the sas transport class sorted out and in use ... at least in
embryo.  I won't hold the drivers up while the fine details and code
location is sorted out, but we need to get at least the structure in
place.

Additionally:


> +static struct device_attribute mptsas_queue_depth_attr = {
> +       .attr = {
> +               .name =         "queue_depth",
> +               .mode =         S_IWUSR,
> +       },
> +       .store = mptscsih_store_queue_depth,
> +};

This can all be done with the change_queue_depth host template API.

There are also a suspicious lot of SPI strings in the SAS driver (are
these cut and paste issues?):


> +       .name                           = "MPT SPI Host",

> +       mptsasDoneCtx = mpt_register(mptscsih_io_done, MPTSPI_DRIVER);
> +       mptsasTaskCtx = mpt_register(mptscsih_taskmgmt_complete,
> MPTSPI_DRIVER);
> +       mptsasInternalCtx = mpt_register(mptscsih_scandv_complete,
> MPTSPI_DRIVER);

James