From: James Bottomley <James.Bottomley@SteelEye.com>
To: Nathan Lynch <ntl@pobox.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
brking@us.ibm.com, linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH] fix slab corruption during ipr probe
Date: Fri, 03 Jun 2005 09:14:04 -0500 [thread overview]
Message-ID: <1117808044.5030.11.camel@mulgrave> (raw)
In-Reply-To: <20050602221509.GA11355@otto>
On Thu, 2005-06-02 at 17:15 -0500, Nathan Lynch wrote:
> This patch works for me (tm); is it correct?
>
> Signed-off-by: Nathan Lynch <ntl@pobox.com>
Yes, it is.
Apparently every other caller except IPR uses the standard
scsi_scan_target() interface, which does have this extra get_device(), I
can't think how it got left off the __scsi_add_device path ... well,
except that it wouldn't show up during testing.
I suppose someone should look at converting ipr to scsi_scan_target()
and we can eliminate this API (the only difference is that
scsi_add_device returns the actual device, but ipr never uses this...)
In the meantime, I'll put this in rc fixes.
Thanks,
James
prev parent reply other threads:[~2005-06-03 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 22:15 [PATCH] fix slab corruption during ipr probe Nathan Lynch
2005-06-03 14:14 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117808044.5030.11.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=brking@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=ntl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox