From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jens Axboe <axboe@suse.de>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
device-mapper development <dm-devel@redhat.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RFC 0/4] use scatter lists for all block pc requests and simplify hw handlers
Date: Tue, 07 Jun 2005 15:38:38 -0400 [thread overview]
Message-ID: <1118173118.4791.17.camel@mulgrave> (raw)
In-Reply-To: <20050607180716.GA8172@suse.de>
On Tue, 2005-06-07 at 20:07 +0200, Jens Axboe wrote:
> I've slowly been doing the same thing in other places in the kernel and
> this bit has been talked about between James and I for at least a year
> or two.
Yes, it's long been a dream of mine to eliminate at least struct
scsi_request and just use block struct request for everything in the
SCSI layer.
The most pleasing aspect of this will be getting rid of the dma mapping
duplications in st and sg.
I'm still not sure we have it entirely correct, though. Something still
needs to be done about the queue alignment constraints, so bio_copy_...
might need to be part of this API.
Also, Jens, this looks wrong (from ll_rw_blk.c around line 2131):
if (!(uaddr & queue_dma_alignment(q)) && !(len & queue_dma_alignment(q)))
The alignment surely wants to be only on the start buffer (otherwise
we'll get spurious copies in variable length commands (like inquiries)?
James
next prev parent reply other threads:[~2005-06-07 20:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-04 1:19 [PATCH RFC 0/4] use scatter lists for all block pc requests and simplify hw handlers Mike Christie
2005-06-04 16:07 ` James Bottomley
2005-06-05 7:15 ` Mike Christie
2005-06-05 9:41 ` [dm-devel] " christophe varoqui
2005-06-06 13:31 ` Lars Marowsky-Bree
2005-06-07 0:04 ` Michael Christie
2005-06-07 7:01 ` [dm-devel] " Lars Marowsky-Bree
2005-06-05 14:40 ` James Bottomley
2005-06-05 19:11 ` James Bottomley
2005-06-06 5:43 ` Douglas Gilbert
2005-06-06 14:19 ` James Bottomley
2005-06-07 13:08 ` Douglas Gilbert
2005-06-07 13:34 ` Tony Battersby
2005-06-07 16:34 ` James Bottomley
2005-06-07 18:38 ` [PATCH RFC 0/4] use scatter lists for all blockpc " Tony Battersby
2005-06-07 18:43 ` Jens Axboe
2005-06-07 15:59 ` [PATCH RFC 0/4] use scatter lists for all block pc " James Bottomley
2005-06-07 18:07 ` Jens Axboe
2005-06-07 19:26 ` James Bottomley
2005-06-08 7:09 ` Jens Axboe
2005-06-06 19:02 ` Patrick Mansfield
2005-06-07 15:26 ` Michael Christie
2005-06-07 18:23 ` Patrick Mansfield
2005-06-08 15:41 ` Mike Christie
2005-06-09 0:08 ` Patrick Mansfield
2005-06-09 6:18 ` Jens Axboe
2005-06-09 11:51 ` James Bottomley
2005-06-09 11:54 ` Jens Axboe
2005-06-07 12:10 ` Christoph Hellwig
2005-06-07 12:20 ` James Bottomley
2005-06-07 15:36 ` Michael Christie
2005-06-07 15:45 ` [dm-devel] " Michael Christie
2005-06-07 16:26 ` Kai Makisara
2005-06-07 19:23 ` James Bottomley
2005-06-07 18:09 ` Jens Axboe
2005-06-08 12:46 ` Mike Christie
2005-06-07 18:07 ` Jens Axboe
2005-06-07 19:38 ` James Bottomley [this message]
2005-06-08 3:00 ` Douglas Gilbert
2005-06-08 12:59 ` James Bottomley
2005-06-08 14:50 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118173118.4791.17.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox