Re: Fw: ahc_target_state check starget valid

[James Bottomley <James.Bottomley@SteelEye.com>]

On Wed, 2005-06-22 at 14:08 -0700, Andrew Morton wrote:
> Nope, Justin has departed the scene.  I think someone at adaptec has picked
> up maintenance, but James dinks with aic* as well.  MAINTAINERS needs some
> maintenance.

Well, Adaptec has more or less abandoned the aic7xxx series of drivers,
apparently, so I've been trying to get the one which I actually have
hardware for into some type of shape.

The patch is functional, but not quite complete, the bug being checking
starg (as the original code did) instead of starget, so the complete
patch takes out the superfluous if (starg == NULL) as well.

James

diff --git a/drivers/scsi/aic7xxx/aic7xxx_proc.c b/drivers/scsi/aic7xxx/aic7xxx_proc.c
--- a/drivers/scsi/aic7xxx/aic7xxx_proc.c
+++ b/drivers/scsi/aic7xxx/aic7xxx_proc.c
@@ -155,9 +155,9 @@ ahc_dump_target_state(struct ahc_softc *
 	copy_info(info, "\tUser: ");
 	ahc_format_transinfo(info, &tinfo->user);
 	starget = ahc->platform_data->starget[target_offset];
-	targ = scsi_transport_target_data(starget);
-	if (targ == NULL)
+	if (!starget)
 		return;
+	targ = scsi_transport_target_data(starget);
 
 	copy_info(info, "\tGoal: ");
 	ahc_format_transinfo(info, &tinfo->goal);