From: Arjan van de Ven <arjan@infradead.org>
To: "Hammer, Jack" <Jack_Hammer@adaptec.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: ServeRAID V7.12
Date: Fri, 22 Jul 2005 10:53:07 -0400 [thread overview]
Message-ID: <1122043987.3577.35.camel@localhost.localdomain> (raw)
In-Reply-To: <A121ABA5B472B74EB59076B8E3C8F0190153418E@rtpe2k01.adaptec.com>
>
>
> --- a/drivers/scsi/ips.c Tue Jul 19 13:15:24 2005
> +++ b/drivers/scsi/ips.c Tue Jul 19 13:12:44 2005
> @@ -133,10 +133,12 @@
>
> #ifdef MODULE
> static char *ips = NULL;
> -module_param(ips, charp, 0);
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,25)
> +MODULE_PARM(ips, "s");
> +#else
> +#include <linux/moduleparam.h>
> +#define MAX_BOOT_OPTIONS_SIZE 256
> +static char boot_options[MAX_BOOT_OPTIONS_SIZE];
> +module_param_string(ips, boot_options, MAX_BOOT_OPTIONS_SIZE, 0);
> +#endif
> #endif
this looks like a major code quality regression!
In fact, the outer MODULE ifdef should also go away
> #ifdef MODULE
> - if (ips)
> - ips_setup(ips);
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,25)
> + ips = boot_options;
> +#endif
> + if (ips)
> + ips_setup(ips);
this looks like a code clutter for a 2.6 driver
next prev parent reply other threads:[~2005-07-22 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-22 14:16 ServeRAID V7.12 Hammer, Jack
2005-07-22 14:53 ` Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-22 16:13 Hammer, Jack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1122043987.3577.35.camel@localhost.localdomain \
--to=arjan@infradead.org \
--cc=Jack_Hammer@adaptec.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox