From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] add transport class symlink to device object Date: Mon, 15 Aug 2005 17:41:17 -0500 Message-ID: <1124145677.5089.68.camel@mulgrave> References: <9BB4DECD4CFE6D43AA8EA8D768ED51C201AD35@xbl3.ma.emulex.com> <20050813213955.GB19235@kroah.com> <20050814150231.GA9466@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from stat16.steeleye.com ([209.192.50.48]:51664 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S965019AbVHOWli (ORCPT ); Mon, 15 Aug 2005 18:41:38 -0400 In-Reply-To: <20050814150231.GA9466@parcelfarce.linux.theplanet.co.uk> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox Cc: Greg KH , James.Smart@Emulex.Com, Andrew Morton , SCSI Mailing List , Linux Kernel , Alan Cox , Russell King On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote: > /sys/class/tty/ttyS0/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > /sys/class/tty/ttyS1/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > /sys/class/tty/ttyS2/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:04.0 > /sys/class/tty/ttyS3/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:05.0 > /sys/class/tty/ttyS4/device -> ../../../devices/parisc/0/0:0/pci0000:00/0000:00:05.0 Actually, isn't the fix to all of this to combine Greg and James' patches? The Greg one fails in SCSI because we don't have unique class device names (by convention we use the same name as the device bus_id) and James' one fails for ttys because the class name isn't unique. However, if the link were derived from something like : Then is would be unique in both cases. Unless anyone can think of any more failing cases? James