public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/16]  qla2xxx: Correct ISP24xx soft-reset handling.
Date: Fri, 26 Aug 2005 21:26:21 -0500	[thread overview]
Message-ID: <1125109581.5079.160.camel@mulgrave> (raw)
In-Reply-To: <20050827020820.27275.23899.sendpatchset@plap.qlogic.com>

On Fri, 2005-08-26 at 19:08 -0700, Andrew Vasquez wrote:
>  		WRT_REG_DWORD(&reg->ctrl_status,
>  		    CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
> -		RD_REG_DWORD(&reg->ctrl_status);
> +		/*
> +		 * It is necessary to delay here since the card doesn't respond
> +		 * to PCI reads during a reset. On some architectures this will
> +		 * result in an MCA.
> +		*/
> +		udelay(100);

Removing the read introduces a potential write posting bug, doesn't?
And again:


> @@ -589,10 +589,14 @@ qla24xx_reset_risc(scsi_qla_host_t *ha)
>  
>         WRT_REG_DWORD(&reg->ctrl_status,
>             CSRX_ISP_SOFT_RESET|CSRX_DMA_SHUTDOWN|MWB_4096_BYTES);
> -       RD_REG_DWORD(&reg->ctrl_status);

James



  reply	other threads:[~2005-08-27  2:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-27  2:07 [PATCH 0/16] qla2xxx: update qla2xxx driver to 8.01.00 Andrew Vasquez
2005-08-27  2:08 ` [PATCH 1/16] qla2xxx: Use dma_get_required_mask() in determining the 'ideal' DMA mask Andrew Vasquez
2005-08-27  2:08 ` [PATCH 2/16] qla2xxx: Export class-of-service (COS) information Andrew Vasquez
2005-08-27  2:08 ` [PATCH 3/16] qla2xxx: Correct ISP24xx soft-reset handling Andrew Vasquez
2005-08-27  2:26   ` James Bottomley [this message]
2005-08-29 16:04     ` Andrew Vasquez
2005-08-27  2:08 ` [PATCH 4/16] qla2xxx: Add FDMI support Andrew Vasquez
2005-08-27  2:08 ` [PATCH 5/16] qla2xxx: Correct domain/area exclusion logic Andrew Vasquez
2005-08-27  2:08 ` [PATCH 6/16] qla2xxx: Simplify redundant target/device reset logic Andrew Vasquez
2005-08-27  2:09 ` [PATCH 7/16] qla2xxx: Correct LED scheme definition Andrew Vasquez
2005-08-27  2:09 ` [PATCH 8/16] qla2xxx: Remove RISC pause/release barriers during flash manipulation Andrew Vasquez
2005-08-27  2:09 ` [PATCH 9/16] qla2xxx: Remove redundant call to pci_unmap_sg() Andrew Vasquez
2005-08-27  2:09 ` [PATCH 10/16] qla2xxx: Add change_queue_depth/type() API support Andrew Vasquez
2005-08-27  2:09 ` [PATCH 11/16] qla2xxx: Add host attributes Andrew Vasquez
2005-08-27  2:09 ` [PATCH 12/16] qla2xxx: Generalize WWN to u64 interger conversions Andrew Vasquez
2005-08-27 10:40   ` Christoph Hellwig
2005-08-31 22:18     ` [PATCH 1/3] " Andrew Vasquez
2005-08-31 22:21       ` [PATCH 2/3] qla2xxx: use wwn_to_u64() transport helper Andrew Vasquez
2005-08-31 22:23       ` [PATCH 3/3] lpfc: " Andrew Vasquez
2005-09-05 12:26       ` [PATCH 1/3] Generalize WWN to u64 interger conversions Christoph Hellwig
2005-08-27  2:10 ` [PATCH 13/16] qla2xxx: Remove bad call to fc_remove_host() during probe failure Andrew Vasquez
2005-08-27  2:10 ` [PATCH 14/16] qla2xxx: Replace schedule_timeout() Andrew Vasquez
2005-08-27  2:10 ` [PATCH 15/16] qla2xxx: Stop firmware execution at unintialization time Andrew Vasquez
2005-08-27  2:10 ` [PATCH 16/16] qla2xxx: Update version number to 8.01.00-k Andrew Vasquez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1125109581.5079.160.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox