Re: [PATCH 1/5] SCSI scanning and removal fixes

[James Bottomley <James.Bottomley@SteelEye.com>]

On Tue, 2005-07-26 at 10:12 -0400, Alan Stern wrote:
> This patch (as542) fixes a few loose ends left by Mike's patches.  It adds 
> a declaration for the new scsi_host_set_state routine, adds an allowed 
> transition from the SHOST_RECOVERY state to the SHOST_CANCEL state, and 
> avoids returning an uninitialized value in __scsi_add_device.

The first part (external declaration) is already in.

The second (allow RECOVERY->CANCEL) isn't really an answer.  The correct
thing, I suppose, is to have scsi_remove_host() wait for the error
handler to finish if the state transition cannot be accomodated
(otherwise the error handler will try to transition ->RUNNING part way
through the removal).

The third (don't allow uninitialised return from __scsi_add_device) is
correct, but the return is universally ignored (the only actual user
being ipr).  Unfortunately, now I look at this, ipr gets it wrong too.
This API currently returns an sdev with an incremented refcount.  If you
ignore the return, as ipr does, you're leaking refcounts.  So, since the
only user gets it wrong all the time, I'd vote for modifying the API not
to return a device.

James