From: James Bottomley <James.Bottomley@SteelEye.com>
To: Christoph Hellwig <hch@lst.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SAS transport class
Date: Fri, 09 Sep 2005 18:38:27 -0500 [thread overview]
Message-ID: <1126309108.4799.57.camel@mulgrave> (raw)
In-Reply-To: <20050909142250.GA13136@lst.de>
On Fri, 2005-09-09 at 16:22 +0200, Christoph Hellwig wrote:
> I think this submission is ready for 2.6.14, but additional comments are
> of course very welcome.
Actually, you missed a prototype change for the class functions.
James
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -156,7 +156,8 @@ sas_bitfield_name_search(linkspeed, sas_
* SAS host attributes
*/
-static int sas_host_setup(struct device *dev)
+static int sas_host_setup(struct transport_container *tc, struct device *dev,
+ struct class_device *cdev)
{
struct Scsi_Host *shost = dev_to_shost(dev);
struct sas_host_attrs *sas_host = to_sas_host_attrs(shost);
next prev parent reply other threads:[~2005-09-09 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 14:22 [PATCH] SAS transport class Christoph Hellwig
2005-09-09 14:35 ` James Bottomley
2005-09-09 14:38 ` Christoph Hellwig
2005-09-09 23:38 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-06 14:24 James.Smart
2005-09-06 13:40 James.Smart
2005-09-06 14:00 ` Christoph Hellwig
2005-09-06 16:00 ` Stefan Richter
2005-09-04 23:50 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126309108.4799.57.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox