Re: [PATCH] set error value when failing block pc commands in prep_fn

[James Bottomley <James.Bottomley@SteelEye.com>]

On Sat, 2005-09-10 at 13:59 -0500, Mike Christie wrote:
> This patch is updated against scsi-rc-fixes which has
> Alan's patch that fixes the places where we did not set
> a error value in the request_fn.
> 
> But when we kill a block pc request in the prep function
> the  errors value is still not getting set. And if scsi_init_io
> returned BLKPREP_DEFER we missed the blk_plug_device code so
> this patch just has it go to the defer label in that case.
> 
> Patch was made against scsi-rc-fixes.

Is there a reason we shouldn't be setting the error in all cases?  I
certainly can't think of one, in which case just set it globally.
There's also a return BLKPREP_DEFER on line 1191:

	if(unlikely(specials_only) && !(req->flags & REQ_SPECIAL)) {
		if(specials_only == SDEV_QUIESCE ||
				specials_only == SDEV_BLOCK)
			return BLKPREP_DEFER;

That needs to become a goto defer; for the same reasons as outlined
above.

James