From: Mike Christie <michaelc@cs.wisc.edu>
To: axboe@suse.de, Kai Makisara <Kai.Makisara@kolumbus.fi>,
linux-scsi@vger.kernel.org
Subject: [PATCH] dont retry on SG_IO tape commands
Date: Sun, 18 Sep 2005 14:53:11 -0500 [thread overview]
Message-ID: <1127073191.3067.1.camel@max> (raw)
sd does not allow scsi_io_completion to retry commands for
SG_IO requests, and it make sense that it should not happen for st
SG_IO commands too. This patch returns to the block layer that
the whole command completed and relies on the caller to check
the request errors field.
Patch was made against scsi-rc-fixes.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
static void st_intr(struct scsi_cmnd *SCpnt)
{
- scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
+ scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
}
/*
next reply other threads:[~2005-09-18 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 19:53 Mike Christie [this message]
2005-09-18 20:46 ` [PATCH] dont retry on SG_IO tape commands Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127073191.3067.1.camel@max \
--to=michaelc@cs.wisc.edu \
--cc=Kai.Makisara@kolumbus.fi \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).