[PATCH] dont retry on SG_IO tape commands

[PATCH] dont retry on SG_IO tape commands

[Mike Christie]

sd does not allow scsi_io_completion to retry commands for
SG_IO requests, and it make sense that it should not happen for st
SG_IO commands too. This patch returns to the block layer that
the whole command completed and relies on the caller to check
the request errors field.

Patch was made against scsi-rc-fixes.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
 
 static void st_intr(struct scsi_cmnd *SCpnt)
 {
-	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
+	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
 }
 
 /*

Re: [PATCH] dont retry on SG_IO tape commands

[Mike Christie]

Actually forget this patch. We can just make scsi-ml handle this.


Mike Christie wrote:
> sd does not allow scsi_io_completion to retry commands for
> SG_IO requests, and it make sense that it should not happen for st
> SG_IO commands too. This patch returns to the block layer that
> the whole command completed and relies on the caller to check
> the request errors field.
> 
> Patch was made against scsi-rc-fixes.
> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> 
> diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
> --- a/drivers/scsi/st.c
> +++ b/drivers/scsi/st.c
> @@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
>  
>  static void st_intr(struct scsi_cmnd *SCpnt)
>  {
> -	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
> +	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
>  }
>  
>  /*
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html