From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: [PATCH] dont retry on SG_IO tape commands Date: Sun, 18 Sep 2005 14:53:11 -0500 Message-ID: <1127073191.3067.1.camel@max> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:4563 "EHLO sabe.cs.wisc.edu") by vger.kernel.org with ESMTP id S932220AbVIRVxT (ORCPT ); Sun, 18 Sep 2005 17:53:19 -0400 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: axboe@suse.de, Kai Makisara , linux-scsi@vger.kernel.org sd does not allow scsi_io_completion to retry commands for SG_IO requests, and it make sense that it should not happen for st SG_IO commands too. This patch returns to the block layer that the whole command completed and relies on the caller to check the request errors field. Patch was made against scsi-rc-fixes. Signed-off-by: Mike Christie diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre static void st_intr(struct scsi_cmnd *SCpnt) { - scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1); + scsi_io_completion(SCpnt, SCpnt->bufflen, 0); } /*