Re: [PATCH 1/4] sas: add flag for locally attached PHYs

Luben Tuikov
2005-10-19T19:38:00Z

On 10/19/05 15:24, Luben Tuikov wrote:
> On 10/19/05 14:01, Christoph Hellwig wrote:
>
>>Add a flag to mark a PHY as attached to the HBA as opposed to beeing on
>>an expander. This is needed because various features are only supported
>>on those. This is a crude hack, the proper fix would be to use
>>different classes for host-attached vs expander phys. I'm looking into
>>that.
>
>
> The phy isn't quite "attached" -- i.e. at software level you do not
> care about that. At least I've never heard anyone (not of "the community")
> say that a phy is "attached".
>
> You don't need to represent that. While you can, you completely do not
> need to do it. All you should care about is the _port_. Take a look
> at SAS section 4.
>
> Also take a look at:
> drivers/scsi/sas/sas_phy.c,
> drivers/scsi/sas/sas_port.c and
> drivers/scsi/sas/sas_discover.c .
>
> Storage GUI applications can read the expander configuration using SMP
> and show this as I've shown in Announcement 1 here:
> http://marc.theaimsgroup.com/?l=linux-scsi&m=112629509826900&w=2

And Announcement 2 (more specifically using the user space configuration
utility program "expander_conf.c"):
http://marc.theaimsgroup.com/?l=linux-scsi&m=112629509318354&w=2

Luben
--
http://linux.adaptec.com/sas/
http://www.adaptec.com/sas/

> All you should care about is the _local_ phys since those are
> under your control, and the port formed.
>
> Luben