From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>,
Dale Blount <linux-kernel@dale.us>
Subject: Re: [PATCH] scsi disk: report size without overflow
Date: Fri, 21 Oct 2005 16:17:17 -0500 [thread overview]
Message-ID: <1129929437.3440.60.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.58.0510211345080.32061@shark.he.net>
On Fri, 2005-10-21 at 13:46 -0700, Randy.Dunlap wrote:
> On Fri, 21 Oct 2005, James Bottomley wrote:
> > what's wrong with the attached? It looks like the code once allowed 256
> > byte sectors, but the if statement above now forbids them.
>
> What if statement forbids 256-byte sectors? I don't see it.
>
> if (sector_size != 512 &&
> sector_size != 1024 &&
> sector_size != 2048 &&
> sector_size != 4096 &&
> sector_size != 256) {
Sorry, didn't read far enough down the if statement.
To support 256, we can still do it, but the assignment has to become
sector_t sz = (sdkp->capacity/2) * (hard_sector/256);
James
next prev parent reply other threads:[~2005-10-21 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-21 3:55 [PATCH] scsi disk: report size without overflow Randy.Dunlap
2005-10-21 17:20 ` James Bottomley
2005-10-21 20:46 ` Randy.Dunlap
2005-10-21 21:02 ` Dale Blount
2005-10-22 14:44 ` James Bottomley
2005-10-21 21:17 ` James Bottomley [this message]
2005-10-22 2:24 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129929437.3440.60.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@dale.us \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox